Commits · 3e440366f5f5472e401888987c9593402acbc6aa · Jérome Perrin / neoppod

31 Jul, 2009 5 commits

When the primary lost a secondary, it have to set it in down state and broadcast · 3e440366

Grégory Wisniewski authored Jul 31, 2009

the information to others.
Remove an XXX: As for client node, a master don't leep its UUID, so it have to
be dropped from nodes managers.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1121 71dcc9de-d417-0410-9af5-da40c76e7ee4

3e440366

Allow create a new cluster with more than one storage node, this is controlled · 5912c7f7

Grégory Wisniewski authored Jul 31, 2009

by the REQUIRED_NODE_NUMBER definition, and keep the default with one node.
Add a XXX about broadcastNodeInformation possible improvement.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1120 71dcc9de-d417-0410-9af5-da40c76e7ee4

5912c7f7

Bug fix: ServerSocket was not set in non-blocking mode, causing the master wait · c31dc434

Grégory Wisniewski authored Jul 31, 2009

on the recv() until a ping was sent to it. Now the non-bloking state is defined
in the Connector __init__ to ensure all sockets will not block.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1118 71dcc9de-d417-0410-9af5-da40c76e7ee4

c31dc434

When the disconnection is not caused by a broken node event, pick the state... · 92f2ab72

Vincent Pelletier authored Jul 31, 2009

When the disconnection is not caused by a broken node event, pick the state from a mapping: by default, a disconnected node is considered down (ie, removed from node manager as soon as it gets disconnected), with the exception of a storage node (it must be kept in partition table, so it must also be kept in node manager).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1117 71dcc9de-d417-0410-9af5-da40c76e7ee4

92f2ab72

Do not silently ignore an unknown node in disconnection handler method. Any... · 7990c1dc

Vincent Pelletier authored Jul 31, 2009

Do not silently ignore an unknown node in disconnection handler method. Any node being disconnedted at the level of this handler must be known, otherwise it's a bug.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1116 71dcc9de-d417-0410-9af5-da40c76e7ee4

7990c1dc

30 Jul, 2009 23 commits

Add a task in the TODO list. · 3c0e72ff

Grégory Wisniewski authored Jul 30, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1115 71dcc9de-d417-0410-9af5-da40c76e7ee4

3c0e72ff

Since the startup/recovery cluster process is now manually handled, we don't · ce1574c1

Grégory Wisniewski authored Jul 30, 2009

care about greater IDs received in service state, we don't have to receive this
packet.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1114 71dcc9de-d417-0410-9af5-da40c76e7ee4

ce1574c1

Bug fix: Client now put fake packet in queue to release requesting thread, and · c9d2c07b

Grégory Wisniewski authored Jul 30, 2009

use Dispatcher.unregister() to avoid duplicates.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1113 71dcc9de-d417-0410-9af5-da40c76e7ee4

c9d2c07b

Make count_dict property always contain all nodes, even if they are registered... · 63f617bb

Vincent Pelletier authored Jul 30, 2009

Make count_dict property always contain all nodes, even if they are registered for the first time in FEEDING state.
This fixes the annoying KeyError raised in log method when it happens.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1112 71dcc9de-d417-0410-9af5-da40c76e7ee4

63f617bb

Uncomment required code to make RLock class be detected as reentrant. · cd29ad22
Vincent Pelletier authored Jul 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1111 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
cd29ad22

Improve lock tracing: · 8f2ba439

Vincent Pelletier authored Jul 30, 2009

- Don't complain about deadlocks when reentrant (they cannot happen on a single lock, and more complex deadlocks are just not reported here)
- Display a complete traceback when a deadlock is detected (just displaying the line acquiring the lock is sometimes not enough).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1110 71dcc9de-d417-0410-9af5-da40c76e7ee4

8f2ba439

Add an entry in the TODO list about send ask() packets from the client thread · bba0e284
Grégory Wisniewski authored Jul 30, 2009
```
poll.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1109 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
bba0e284

Client don't have to register a storage if not found by server address. First · 99a52d3c

Grégory Wisniewski authored Jul 30, 2009

this must be already done, then if node object already exist, so create another
is wrong.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1108 71dcc9de-d417-0410-9af5-da40c76e7ee4

99a52d3c

Fix enableStorageList method that expect an uuid list instead of a node list. · 21fd729f

Grégory Wisniewski authored Jul 30, 2009

This fix the use of 'neoctl add all'.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1107 71dcc9de-d417-0410-9af5-da40c76e7ee4

21fd729f

Don't include Enum representation in EnumItem __repr__ implementation to improve · 1865a291
Grégory Wisniewski authored Jul 30, 2009
```
message readability.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1106 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
1865a291
Master register unknown storage node found in the proposed partition table. · 132d5f2c
Grégory Wisniewski authored Jul 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1105 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
132d5f2c

Fix method handler that drop the admin node from the manager, so it can come · a1c254ac

Grégory Wisniewski authored Jul 30, 2009

back without be rejected due to invalid server address.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1104 71dcc9de-d417-0410-9af5-da40c76e7ee4

a1c254ac

Only handle partition change notification if the partition is already filled. · 53247b42
Vincent Pelletier authored Jul 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1103 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
53247b42

Remove a false call to super method. · 46174b92

Grégory Wisniewski authored Jul 30, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1102 71dcc9de-d417-0410-9af5-da40c76e7ee4

46174b92

Set the partition table id after clearing it, as that process involves resetting the table id. · 8fbf715e
Vincent Pelletier authored Jul 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1101 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8fbf715e
Decode error codes properly, now that they became EnumItems. · e5b973ef
Vincent Pelletier authored Jul 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1100 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
e5b973ef
Make error code become EnumItems to get a better string representation. · 0bfacc9e
Vincent Pelletier authored Jul 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1099 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
0bfacc9e

Factorise packet logging code. · 2cd1a166

Vincent Pelletier authored Jul 30, 2009

Add a more detailed logging of ERROR packets (print error code and message).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1098 71dcc9de-d417-0410-9af5-da40c76e7ee4

2cd1a166

Don't close the connection in connectionTimeout event, because this job is done · a3e44f99

Grégory Wisniewski authored Jul 30, 2009

in event.py, now before trigger the event. It's thread-safe because the
connection is locked around the close().

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1097 71dcc9de-d417-0410-9af5-da40c76e7ee4

a3e44f99

Remove some FIXME added or already present in the TODO list. · 5dfc4fdb
Grégory Wisniewski authored Jul 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1096 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5dfc4fdb

Merge two dict definition from node.py and pt.py, to protocol.py. · 3f209f29

Grégory Wisniewski authored Jul 30, 2009

Rename partition_cell_states to cell_states to match with other names.
Fix indent and unify imports.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1095 71dcc9de-d417-0410-9af5-da40c76e7ee4

3f209f29

Rename Node.getNodeType to Node.getType for consistency with None.getState. · fbbb07ea
Grégory Wisniewski authored Jul 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1094 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
fbbb07ea

Rename is(Server|Client|Listening)Connection without the 'Connection' suffix, · d8a1d43d

Grégory Wisniewski authored Jul 30, 2009

because there are Connection class atttributes.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1093 71dcc9de-d417-0410-9af5-da40c76e7ee4

d8a1d43d

29 Jul, 2009 12 commits

Client's storage handler use connectionLost hook. · f532bbbc

Grégory Wisniewski authored Jul 29, 2009

Storage node register unknown storage node found in the database before loading
the content into the partition table. So an update() can now expect to known the
storage node.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1092 71dcc9de-d417-0410-9af5-da40c76e7ee4

f532bbbc

On the way of the previous commit, handleConnectionLost is now defined and · 82c18e80

Grégory Wisniewski authored Jul 29, 2009

called from the generic handler. This allow use it in some part of client and
storage handlers.
Add some XXX...


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1091 71dcc9de-d417-0410-9af5-da40c76e7ee4

82c18e80

Clarify use of _nodeLost/_dropIt methods by: · 14eafdd4

Grégory Wisniewski authored Jul 29, 2009

- Renaming _nodeLost to _handleConnectionLost and removing the node parameter
whose the computation was done before each call to it.
- Renaming _dropIt to handleNodeLost, currently called only from the base
service handler, so the abstract definition as moved into it. In this case, a
call ensure that the node is not None.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1090 71dcc9de-d417-0410-9af5-da40c76e7ee4

14eafdd4

Remove dealWithClientFailure from the base storage event handler class and it's · a2a4aa35

Grégory Wisniewski authored Jul 29, 2009

call because the implementation do nothing. This is used only in
ClientEventHandler and so, no overloading is required.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1089 71dcc9de-d417-0410-9af5-da40c76e7ee4

a2a4aa35

Define is(Client|Server|Listening)Connection on the BaseConnection class to · 27de0880

Grégory Wisniewski authored Jul 29, 2009

ensure any acces to those methods can be done on any connection from the event
manager without crash the applications. This way is not less consistent than the
previous where isServerConnection was defined on ClientConnection and so on...
Replace any isinstance() calls with a connection as parameter by call to the
attributes above.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1088 71dcc9de-d417-0410-9af5-da40c76e7ee4

27de0880

A master that has just switch to the secondary state can receive a notification · 5160976a
Grégory Wisniewski authored Jul 29, 2009
```
about the cluster state.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1087 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5160976a

Add some ideas in the TODO list. · 51576dd1

Grégory Wisniewski authored Jul 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1086 71dcc9de-d417-0410-9af5-da40c76e7ee4

51576dd1

Fix a typo in protocol, add unregister() method on Dispatcher for consistency · 8aed780b

Grégory Wisniewski authored Jul 29, 2009

adn remove an XXX. Unify imports for protocol, remove unused variable.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1085 71dcc9de-d417-0410-9af5-da40c76e7ee4

8aed780b

Delete some unused variables. · 6772d446

Grégory Wisniewski authored Jul 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1084 71dcc9de-d417-0410-9af5-da40c76e7ee4

6772d446

Remove an XXX and add a TODO entry for this issue. · 86705c29

Grégory Wisniewski authored Jul 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1083 71dcc9de-d417-0410-9af5-da40c76e7ee4

86705c29

Remove notifyDeadNode from client app because it's no more used. The client node · 2d1f4090

Grégory Wisniewski authored Jul 29, 2009

never send notifyNodeInformation packets to the master (and don't need to do
this), so remove the associated method handler on the master side and thus
remove an XXX.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1082 71dcc9de-d417-0410-9af5-da40c76e7ee4

2d1f4090

Master recovery handler use PartitionTable.load() that clear the content if the · 04d6a839

Grégory Wisniewski authored Jul 29, 2009

ptid is different. 
Storage node no more use a 'ptid' attribute on the app instance but use the
getID() accessor from the PartitionTable class.
PartitionTable.clear() now also reset the ptid.
PartitionTable.load() do more checks (taken from master.recovery)


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1081 71dcc9de-d417-0410-9af5-da40c76e7ee4

04d6a839