From b69b517faef0e1a1d8b713013fcb13430300b51d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9rome=20Perrin?= <jerome@nexedi.com>
Date: Mon, 18 Apr 2016 02:10:51 +0000
Subject: [PATCH] ERP5ShortMessage: fix interface syntax and add some TODO
---
.../interfaces/sms_gateway.py | 24 ++++++++++++-------
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/product/ERP5ShortMessage/interfaces/sms_gateway.py b/product/ERP5ShortMessage/interfaces/sms_gateway.py
index 21e50c6cd6..4495851968 100644
--- a/product/ERP5ShortMessage/interfaces/sms_gateway.py
+++ b/product/ERP5ShortMessage/interfaces/sms_gateway.py
@@ -31,17 +31,23 @@ from zope.interface import Interface
class ISmsGateway(Interface):
- def send(self, text, recipient,
+ def send(text, recipient,
sender=None, sender_title=None,
- message_type="text",test=False, **kw):
- """Send a message."""
+ message_type="text", test=False, **kw):
+ """Send a message.
+
+ TODO: write
- def receive(self, REQUEST):
+ TODO: is getAllowedMessageType part of this API ?
+ shouldn't we rely on content_type ? ( text/plain -> SMS, text/html -> MMS ? )
+ """
+
+ def receive(REQUEST):
"""Public handler to push notification from the gateway"""
- def getAllowedMessageType(self):
- """List of all allowed message type when send a message."""
+ def getAllowedMessageType():
+ """List of all allowed message type when sending a message."""
- def getMessageStatus(self, message_id):
- """Retrive the status of a message
- Should return x in ['sent', 'delivered', 'queued', 'failed']"""
\ No newline at end of file
+ def getMessageStatus(message_id):
+ """Retrieve the status of a message
+ Should return x in ['sent', 'delivered', 'queued', 'failed']"""
--
GitLab