Add a view spec (gasp!) for help/index

spec/views/help/index.html.haml_spec.rb

+require 'rails_helper'
+
+describe 'help/index' do
+  describe 'version information' do
+    it 'is hidden from guests' do
+      stub_user
+      stub_version('8.0.2', 'abcdefg')
+      stub_helpers
+
+      render
+
+      expect(rendered).not_to match '8.0.2'
+      expect(rendered).not_to match 'abcdefg'
+    end
+
+    it 'is hidden from users' do
+      stub_user(admin?: false)
+      stub_version('8.0.2', 'abcdefg')
+      stub_helpers
+
+      render
+
+      expect(rendered).not_to match '8.0.2'
+      expect(rendered).not_to match 'abcdefg'
+    end
+
+    it 'is shown to admins' do
+      stub_user(admin?: true)
+      stub_version('8.0.2', 'abcdefg')
+      stub_helpers
+
+      render
+
+      expect(rendered).to match '8.0.2'
+      expect(rendered).to match 'abcdefg'
+    end
+  end
+
+  def stub_user(messages = {})
+    user = messages.empty? ? nil : double(messages)
+
+    allow(view).to receive(:current_user).and_return(user)
+  end
+
+  def stub_version(version, revision)
+    stub_const('Gitlab::VERSION', version)
+    stub_const('Gitlab::REVISION', revision)
+  end
+
+  def stub_helpers
+    allow(view).to receive(:markdown).and_return('')
+    allow(view).to receive(:current_application_settings).
+      and_return(double.as_null_object)
+  end
+end