Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Z
ZODB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Kirill Smelkov
ZODB
Commits
7a098098
Commit
7a098098
authored
Jun 09, 2007
by
Christian Theune
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
- removed in-code todo list into launchpad or XXX comments
parent
435b3b75
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
36 deletions
+4
-36
src/ZODB/blob.py
src/ZODB/blob.py
+4
-36
No files found.
src/ZODB/blob.py
View file @
7a098098
...
@@ -458,6 +458,10 @@ class BlobStorage(SpecificationDecoratorBase):
...
@@ -458,6 +458,10 @@ class BlobStorage(SpecificationDecoratorBase):
# XXX we should be tolerant of "garbage" directories/files in
# XXX we should be tolerant of "garbage" directories/files in
# the base_directory here.
# the base_directory here.
# XXX If this method gets refactored we have to watch out for extra
# files from uncommitted transactions. The current implementation
# doesn't have a problem, but future refactorings likely will.
base_dir
=
self
.
fshelper
.
base_dir
base_dir
=
self
.
fshelper
.
base_dir
for
oid_repr
in
os
.
listdir
(
base_dir
):
for
oid_repr
in
os
.
listdir
(
base_dir
):
oid
=
utils
.
repr_to_oid
(
oid_repr
)
oid
=
utils
.
repr_to_oid
(
oid_repr
)
...
@@ -591,39 +595,3 @@ class BlobStorage(SpecificationDecoratorBase):
...
@@ -591,39 +595,3 @@ class BlobStorage(SpecificationDecoratorBase):
finally
:
finally
:
self
.
_lock_release
()
self
.
_lock_release
()
return
undo_serial
,
keys
return
undo_serial
,
keys
# To do:
#
# Production
#
# - Ensure we detect and replay a failed txn involving blobs forward or
# backward at startup.
#
# Jim: What does this mean?
#
# Far future
#
# More options for blob directory structures (e.g. dirstorages
# bushy/chunky/lawn/flat).
#
# Make the ClientStorage support minimizing the blob
# cache. (Idea: LRU principle via mstat access time and a
# size-based threshold) currently).
#
# Savepoint support
# =================
#
# - A savepoint represents the whole state of the data at a certain point in
# time
#
# - Need special storage for blob savepointing (in the spirit of tmpstorage)
#
# - What belongs to the state of the data?
#
# - Data contained in files at that point in time
#
# - File handles are complex because they might be referred to from various
# places. We would have to introduce an abstraction layer to allow
# switching them around...
#
# Simpler solution: :
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment