Commit 8f688191 authored by Jeremy Hylton's avatar Jeremy Hylton

Only pass argument to full_sweep() when one is passed by caller.

Add a few comments.
parent 859e180b
...@@ -13,7 +13,7 @@ ...@@ -13,7 +13,7 @@
############################################################################## ##############################################################################
"""Database connection support """Database connection support
$Id: Connection.py,v 1.133 2004/03/02 16:25:07 jeremy Exp $""" $Id: Connection.py,v 1.134 2004/03/04 16:15:55 jeremy Exp $"""
import logging import logging
import sys import sys
...@@ -102,7 +102,7 @@ class Connection(ExportImport, object): ...@@ -102,7 +102,7 @@ class Connection(ExportImport, object):
XXX Mention the database pool. XXX Mention the database pool.
$Id: Connection.py,v 1.133 2004/03/02 16:25:07 jeremy Exp $ $Id: Connection.py,v 1.134 2004/03/04 16:15:55 jeremy Exp $
@group User Methods: root, get, add, close, db, sync, isReadOnly, @group User Methods: root, get, add, close, db, sync, isReadOnly,
cacheGC, cacheFullSweep, cacheMinimize, getVersion, modifiedInVersion cacheGC, cacheFullSweep, cacheMinimize, getVersion, modifiedInVersion
...@@ -194,6 +194,10 @@ class Connection(ExportImport, object): ...@@ -194,6 +194,10 @@ class Connection(ExportImport, object):
def setLocalTransaction(self): def setLocalTransaction(self):
"""Use a transaction bound to the connection rather than the thread""" """Use a transaction bound to the connection rather than the thread"""
# XXX mention that this should only be called when you open
# a connection or at transaction boundaries (but the lattter are
# hard to be sure about).
if self._transaction is None: if self._transaction is None:
self._transaction = Transaction() self._transaction = Transaction()
return self._transaction return self._transaction
...@@ -371,10 +375,13 @@ class Connection(ExportImport, object): ...@@ -371,10 +375,13 @@ class Connection(ExportImport, object):
# XXX we should test what happens when these methods are called # XXX we should test what happens when these methods are called
# mid-transaction. # mid-transaction.
def cacheFullSweep(self, dt=0): def cacheFullSweep(self, dt=None):
# XXX needs doc string # XXX needs doc string
warnings.warn("cacheFullSweep is deprecated. " warnings.warn("cacheFullSweep is deprecated. "
"Use cacheMinimize instead.", DeprecationWarning) "Use cacheMinimize instead.", DeprecationWarning)
if dt is None:
self._cache.full_sweep()
else:
self._cache.full_sweep(dt) self._cache.full_sweep(dt)
def cacheMinimize(self, dt=None): def cacheMinimize(self, dt=None):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment