Deprecate acquiring the request inside Products.ZCatalog's searchResults...

Deprecate acquiring the request inside Products.ZCatalog's searchResults method if no explicit query argument is given.

doc/CHANGES.rst

@@ -35,6 +35,9 @@ Bugs Fixed
 Restructuring
 +++++++++++++
 
+- Deprecate acquiring the request inside Products.ZCatalog's searchResults
+  method if no explicit query argument is given.
+
 - Cleaned up the Products.ZCatalog search API's. The deprecated support for
   using `<index id>_usage` arguments in the request has been removed. Support
   for overriding operators via the `<index id>_operator` syntax has been

src/Products/ZCatalog/Catalog.py

@@ -14,6 +14,7 @@
 
 import types
 import logging
+import warnings
 from bisect import bisect
 from random import randint
 
@@ -770,7 +771,11 @@ class Catalog(Persistent, Acquisition.Implicit, ExtensionClass.Base):
         # The used argument is deprecated and is ignored
         if REQUEST is None and not kw:
             # Try to acquire request if we get no args for bw compat
-            # TODO: Should be deprecated
+            warnings.warn('Calling searchResults without a query argument nor '
+                          'keyword arguments is deprecated. In Zope 2.14 the '
+                          'query will no longer be automatically taken from '
+                          'the acquired request.',
+                          DeprecationWarning, stacklevel=2)
             REQUEST = getattr(self, 'REQUEST', None)
         args = CatalogSearchArgumentsMap(REQUEST, kw)
         sort_index = self._getSortIndex(args)