- don't raise string exceptions

doc/CHANGES.rst

@@ -11,6 +11,7 @@ http://docs.zope.org/zope2/releases/.
 Bugs Fixed
 ++++++++++
 
+- BasicUserFolder and SiteErrorLog: Don't raise string exceptions.
 
 2.12.10 (2010-07-20)
 --------------------

src/AccessControl/User.py

@@ -1003,10 +1003,10 @@ class BasicUserFolder(Implicit, Persistent, Navigation, Tabs, RoleManager,
 
     def _setId(self, id):
         if id != self.id:
-            raise MessageDialog(
+            raise ValueError(MessageDialog(
                 title='Invalid Id',
                 message='Cannot change the id of a UserFolder',
-                action ='./manage_main',)
+                action='./manage_main'))
 
 
     # Domain authentication support. This is a good candidate to

src/Products/SiteErrorLog/SiteErrorLog.py

@@ -103,10 +103,10 @@ class SiteErrorLog (SimpleItem):
 
     def _setId(self, id):
         if id != self.id:
-            raise MessageDialog(
+            raise ValueError(MessageDialog(
                 title='Invalid Id',
                 message='Cannot change the id of a SiteErrorLog',
-                action ='./manage_main',)
+                action='./manage_main'))
 
     def _getLog(self):
         """Returns the log for this object.