Commit f3deac93 authored by Jim Fulton's avatar Jim Fulton

Fixed bugs that caused call to sometimes generate database updates.

parent 8bb5a426
......@@ -60,14 +60,14 @@ class ExternalMethod(OFS.SimpleItem.Item, Persistent, Explicit,
self._function=function
try: del modules[module]
except: pass
self.getFunction()
self.getFunction(1)
if REQUEST: return MessageDialog(
title ='Changed %s' % self.id,
message='%s has been updated' % self.id,
action =REQUEST['URL1']+'/manage_main',
target ='manage_main')
def getFunction(self):
def getFunction(self, check=0):
module=self._module
......@@ -84,6 +84,10 @@ class ExternalMethod(OFS.SimpleItem.Item, Persistent, Explicit,
if hasattr(f,'im_func'): ff=f.im_func
else: ff=f
if check:
# Check to make sure function signature is the same.
# Otherwise, we may end up causing an unwanted change.
if self.func_defaults != ff.func_defaults:
self.func_defaults = ff.func_defaults
......@@ -124,4 +128,4 @@ class FuncCode:
def __cmp__(self,other):
return cmp((self.co_argcount, self.co_varnames),
(othr.co_argcount, othr.co_varnames))
(other.co_argcount, other.co_varnames))
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment