• Grygorii Strashko's avatar
    irqchip/crossbar: Restore the mask on suspend behaviour · 0c7ff29d
    Grygorii Strashko authored
    commit 4fd8f47e upstream.
    
    The ARM GIC requires that all interrupts which are not used as a
    wakeup source have to be masked during suspend.
    
    The conversion of the crossbar irqchip to hierarchical irq domains
    failed to mark the crossbar irqchip with the IRQCHIP_MASK_ON_SUSPEND
    flag and therefor broke the suspend requirement of the GIC.
    
    Before the conversion the flags were visible because the GIC was the
    top level irqchip. After the conversion the crossbar irqchip is the
    top level irq chip whose flags are evaluated in suspend_device_irq().
    As the flag is not set the masking of the non-wakeup irqs is not
    invoked which breaks suspend.
    
    Add the IRQCHIP_MASK_ON_SUSPEND flag to the crossbar irqchip, so the
    GIC interrupts get masked properly.
    
    [ tglx: Massaged changelog ]
    
    Fixes: 783d3186 ('irqchip: crossbar: Convert dra7 crossbar...')
    Signed-off-by: default avatarGrygorii Strashko <grygorii.strashko@ti.com>
    Cc: Sudeep Holla <sudeep.holla@arm.com>
    Cc: <linux@arm.linux.org.uk>
    Cc: <nsekhar@ti.com>
    Cc: <jason@lakedaemon.net>
    Cc: <balbi@ti.com>
    Cc: <linux-arm-kernel@lists.infradead.org>
    Cc: <tony@atomide.com>
    Cc: <marc.zyngier@arm.com>
    Link: http://lkml.kernel.org/r/1439554830-19502-6-git-send-email-grygorii.strashko@ti.comSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    0c7ff29d
irq-crossbar.c 8.37 KB