• Nick Piggin's avatar
    [PATCH] blk: no memory barrier · 250dccc0
    Nick Piggin authored
    This memory barrier is not needed because the waitqueue will only get waiters
    on it in the following situations:
    
    rq->count has exceeded the threshold - however all manipulations of ->count
    are performed under the runqueue lock, and so we will correctly pick up any
    waiter.
    
    Memory allocation for the request fails.  In this case, there is no additional
    help provided by the memory barrier.  We are guaranteed to eventually wake up
    waiters because the request allocation mempool guarantees that if the mem
    allocation for a request fails, there must be some requests in flight.  They
    will wake up waiters when they are retired.
    Signed-off-by: default avatarNick Piggin <nickpiggin@yahoo.com.au>
    Cc: Jens Axboe <axboe@suse.de>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    250dccc0
ll_rw_blk.c 91.1 KB