• Dominique Martinet's avatar
    9p: remove dead stores (variable set again without being read) · cf7c33d3
    Dominique Martinet authored
    The 9p code for some reason used to initialize variables outside of the
    declaration, e.g. instead of just initializing the variable like this:
    
    int retval = 0
    
    We would be doing this:
    
    int retval;
    retval = 0;
    
    This is perfectly fine and the compiler will just optimize dead stores
    anyway, but scan-build seems to think this is a problem and there are
    many of these warnings making the output of scan-build full of such
    warnings:
    fs/9p/vfs_inode.c:916:2: warning: Value stored to 'retval' is never read [deadcode.DeadStores]
            retval = 0;
            ^        ~
    
    I have no strong opinion here, but if we want to regularly run
    scan-build we should fix these just to silence the messages.
    
    I've confirmed these all are indeed ok to remove.
    Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
    Signed-off-by: default avatarDominique Martinet <asmadeus@codewreck.org>
    Signed-off-by: default avatarEric Van Hensbergen <ericvh@kernel.org>
    cf7c33d3
vfs_inode_dotl.c 25.1 KB