• Alexander Steffen's avatar
    tpm_tis: Explicitly check for error code · 513253f8
    Alexander Steffen authored
    recv_data either returns the number of received bytes, or a negative value
    representing an error code. Adding the return value directly to the total
    number of received bytes therefore looks a little weird, since it might add
    a negative error code to a sum of bytes.
    
    The following check for size < expected usually makes the function return
    ETIME in that case, so it does not cause too many problems in practice. But
    to make the code look cleaner and because the caller might still be
    interested in the original error code, explicitly check for the presence of
    an error code and pass that through.
    
    Cc: stable@vger.kernel.org
    Fixes: cb535425 ("[PATCH] tpm: spacing cleanups 2")
    Signed-off-by: default avatarAlexander Steffen <Alexander.Steffen@infineon.com>
    Reviewed-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
    Signed-off-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
    513253f8
tpm_tis_core.c 32.4 KB