• Baoquan He's avatar
    crash: remove dependency of FA_DUMP on CRASH_DUMP · 2c44b67e
    Baoquan He authored
    In kdump kernel, /proc/vmcore is an elf file mapping the crashed kernel's
    old memory content. Its elf header is constructed in 1st kernel and passed
    to kdump kernel via elfcorehdr_addr. Config CRASH_DUMP enables the code
    of 1st kernel's old memory accessing in different architectures.
    
    Currently, config FA_DUMP has dependency on CRASH_DUMP because fadump
    needs access global variable 'elfcorehdr_addr' to judge if it's in
    kdump kernel within function is_kdump_kernel(). In the current
    kernel/crash_dump.c, variable 'elfcorehdr_addr' is defined, and function
    setup_elfcorehdr() used to parse kernel parameter to fetch the passed
    value of elfcorehdr_addr. Only for accessing elfcorehdr_addr, FA_DUMP
    really doesn't have to depends on CRASH_DUMP.
    
    To remove the dependency of FA_DUMP on CRASH_DUMP to avoid confusion,
    rename kernel/crash_dump.c to kernel/elfcorehdr.c, and build it when
    CONFIG_VMCORE_INFO is ebabled. With this, FA_DUMP doesn't need to depend
    on CRASH_DUMP.
    
    [bhe@redhat.com: power/fadump: make FA_DUMP select CRASH_DUMP]
      Link: https://lkml.kernel.org/r/Zb8D1ASrgX0qVm9z@MiWiFi-R3L-srv
    Link: https://lkml.kernel.org/r/20240124051254.67105-4-bhe@redhat.comSigned-off-by: default avatarBaoquan He <bhe@redhat.com>
    Acked-by: default avatarHari Bathini <hbathini@linux.ibm.com>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Eric W. Biederman <ebiederm@xmission.com>
    Cc: Pingfan Liu <piliu@redhat.com>
    Cc: Klara Modin <klarasmodin@gmail.com>
    Cc: Michael Kelley <mhklinux@outlook.com>
    Cc: Nathan Chancellor <nathan@kernel.org>
    Cc: Stephen Rothwell <sfr@canb.auug.org.au>
    Cc: Yang Li <yang.lee@linux.alibaba.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    2c44b67e
elfcorehdr.c 1.14 KB