• Sean Christopherson's avatar
    KVM: Properly unwind VM creation if creating debugfs fails · 4ba4f419
    Sean Christopherson authored
    Properly unwind VM creation if kvm_create_vm_debugfs() fails.  A recent
    change to invoke kvm_create_vm_debug() in kvm_create_vm() was led astray
    by buggy try_get_module() handling adding by commit 5f6de5cb ("KVM:
    Prevent module exit until all VMs are freed").  The debugfs error path
    effectively inherits the bad error path of try_module_get(), e.g. KVM
    leaves the to-be-free VM on vm_list even though KVM appears to do the
    right thing by calling module_put() and falling through.
    
    Opportunistically hoist kvm_create_vm_debugfs() above the call to
    kvm_arch_post_init_vm() so that the "post-init" arch hook is actually
    invoked after the VM is initialized (ignoring kvm_coalesced_mmio_init()
    for the moment).  x86 is the only non-nop implementation of the post-init
    hook, and it doesn't allocate/initialize any objects that are reachable
    via debugfs code (spawns a kthread worker for the NX huge page mitigation).
    
    Leave the buggy try_get_module() alone for now, it will be fixed in a
    separate commit.
    
    Fixes: b74ed7a6 ("KVM: Actually create debugfs in kvm_create_vm()")
    Reported-by: syzbot+744e173caec2e1627ee0@syzkaller.appspotmail.com
    Cc: Oliver Upton <oliver.upton@linux.dev>
    Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
    Reviewed-by: default avatarOliver Upton <oliver.upton@linux.dev>
    Message-Id: <20220816053937.2477106-2-seanjc@google.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    4ba4f419
kvm_main.c 150 KB