• Filipe Manana's avatar
    btrfs: move btrfs_drop_extent_cache() to extent_map.c · 4c0c8cfc
    Filipe Manana authored
    The function btrfs_drop_extent_cache() doesn't really belong at file.c
    because what it does is drop a range of extent maps for a file range.
    It directly allocates and manipulates extent maps, by dropping,
    splitting and replacing them in an extent map tree, so it should be
    located at extent_map.c, where all manipulations of an extent map tree
    and its extent maps are supposed to be done.
    
    So move it out of file.c and into extent_map.c. Additionally do the
    following changes:
    
    1) Rename it into btrfs_drop_extent_map_range(), as this makes it more
       clear about what it does. The term "cache" is a bit confusing as it's
       not widely used, "extent maps" or "extent mapping" is much more common;
    
    2) Change its 'skip_pinned' argument from int to bool;
    
    3) Turn several of its local variables from int to bool, since they are
       used as booleans;
    
    4) Move the declaration of some variables out of the function's main
       scope and into the scopes where they are used;
    
    5) Remove pointless assignment of false to 'modified' early in the while
       loop, as later that variable is set and it's not used before that
       second assignment;
    
    6) Remove checks for NULL before calling free_extent_map().
    Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
    Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    4c0c8cfc
extent_map.h 3.08 KB