• Mauro Carvalho Chehab's avatar
    V4L/DVB (11966): ov511: Fix unit_video parameter behavior · 163fe744
    Mauro Carvalho Chehab authored
    Fix a regression caused by changeset 9133:64aed7485a43 - v4l: disconnect
    kernel number from minor
    
    Before the above changeset, ov511_probe used to allow forcing to use a
    certain specific set of video devices, like:
    
    modprobe ov511 unit_video=4,1,3 num_uv=3
    
    So, assuming that you have 5 ov511 devices, and connect they one by one,
    they'll gain the following device numbers (at the connection order):
    /dev/video4
    /dev/video1
    /dev/video3
    /dev/video0
    /dev/video2
    
    However, this was changed due to this change at video_register_device():
    
    + nr = find_next_zero_bit(video_nums[type], minor_cnt, nr == -1 ? 0 : nr);
    
    With the previous behavior, a trial to register on an already allocated mirror
    would fail, and a loop would get the next requested minor. However, the current
    behavior is to get the next available minor instead of failing. Due to that,
    this means that the above modprobe parameter will give, instead:
    
    /dev/video5
    /dev/video6
    /dev/video7
    /dev/video8
    /dev/video9
    
    In order to restore the original behavior, a static var were added,
    storing the amount of already registered devices.
    
    While there, it also fixes the locking of the probe/disconnect functions.
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
    163fe744
ov511.h 16.1 KB