• Ian Rogers's avatar
    perf tools: Warn if no user requested CPUs match PMU's CPUs · 5ac72634
    Ian Rogers authored
    In commit 1d3351e6 ("perf tools: Enable on a list of CPUs for hybrid")
    perf on hybrid will warn if a user requested CPU doesn't match the PMU
    of the given event but only for hybrid PMUs. Make the logic generic
    for all PMUs and remove the hybrid logic.
    
    Warn if a CPU is requested that isn't present/offline for events not
    on the core. Warn if a CPU is requested for a core PMU, but the CPU
    isn't within the cpu map of that PMU.
    
    For example on a 16 (0-15) CPU system:
    ```
    $ perf stat -e imc_free_running/data_read/,cycles -C 16 true
    WARNING: A requested CPU in '16' is not supported by PMU 'uncore_imc_free_running_1' (CPUs 0-15) for event 'imc_free_running/data_read/'
    WARNING: A requested CPU in '16' is not supported by PMU 'uncore_imc_free_running_0' (CPUs 0-15) for event 'imc_free_running/data_read/'
    WARNING: A requested CPU in '16' is not supported by PMU 'cpu' (CPUs 0-15) for event 'cycles'
    
     Performance counter stats for 'CPU(s) 16':
    
       <not supported> MiB  imc_free_running/data_read/
       <not supported>      cycles
    
           0.000575312 seconds time elapsed
    ```
    
    Remove evlist__fix_hybrid_cpus that previously produced the warnings
    and also perf_pmu__cpus_match that worked with evlist__fix_hybrid_cpus
    to change CPU maps for hybrid CPUs, something that is no longer
    necessary as CPU map propagation properly intersects user requested
    CPUs with the core PMU's CPU map.
    Reviewed-by: default avatarKan Liang <kan.liang@linux.intel.com>
    Signed-off-by: default avatarIan Rogers <irogers@google.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Ali Saidi <alisaidi@amazon.com>
    Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
    Cc: Dmitrii Dolgov <9erthalion6@gmail.com>
    Cc: Huacai Chen <chenhuacai@kernel.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: James Clark <james.clark@arm.com>
    Cc: Jing Zhang <renyu.zj@linux.alibaba.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: John Garry <john.g.garry@oracle.com>
    Cc: Kajol Jain <kjain@linux.ibm.com>
    Cc: Kang Minchul <tegongkang@gmail.com>
    Cc: Leo Yan <leo.yan@linaro.org>
    Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Mike Leach <mike.leach@linaro.org>
    Cc: Ming Wang <wangming01@loongson.cn>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Ravi Bangoria <ravi.bangoria@amd.com>
    Cc: Rob Herring <robh@kernel.org>
    Cc: Sandipan Das <sandipan.das@amd.com>
    Cc: Sean Christopherson <seanjc@google.com>
    Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
    Cc: Thomas Richter <tmricht@linux.ibm.com>
    Cc: Will Deacon <will@kernel.org>
    Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com>
    Cc: coresight@lists.linaro.org
    Cc: linux-arm-kernel@lists.infradead.org
    Link: https://lore.kernel.org/r/20230527072210.2900565-12-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    5ac72634
evlist-hybrid.c 1.8 KB