• Stephane Eranian's avatar
    perf tools: fix broken perf record -a mode · 6b1bee90
    Stephane Eranian authored
    The following commit:
    b52956c9 perf tools: Allow multiple threads or processes in record, stat, top
    
    introduced a bug in the thread_map code which caused perf record -a to
    not setup system-wide monitoring properly.
    
    $ taskset -c 1 noploop 1000 &
    $ perf record -a -C 1 sleep 10
    $ perf report -D | tail -20
    cycles stats:
               TOTAL events:       4413
                MMAP events:       4025
                COMM events:        340
              SAMPLE events:         48
    
    Here I was expecting about 10,000 samples and not 48.
    
    In system-wide mode, the PID passed to perf_event_open() must be -1 and
    it was 0. That caused the kernel to setup a per-process event on PID:0.
    Consequently, the number of samples captured does not correspond to the
    requested measurement.
    
    The following one-liner fixes the problem for me with or without -C.
    
    I would also suggest to change the malloc() to something that matches
    the struct definition. thread_map->map[] is declared as int map[] and
    not pid_t map[]. If map[] can only contain pids, then change the struct
    definition.
    Acked-by: default avatarDavid Ahern <dsahern@gmail.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Eric Dumazet <eric.dumazet@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lkml.kernel.org/r/20120221145424.GA6757@quadSigned-off-by: default avatarStephane Eranian <eranian@google.com>
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    6b1bee90
thread_map.c 5.83 KB