• Zheyu Ma's avatar
    video: fbdev: s3fb: Error out if 'pixclock' equals zero · 7015bb57
    Zheyu Ma authored
    The userspace program could pass any values to the driver through
    ioctl() interface. If the driver doesn't check the value of 'pixclock',
    it may cause divide error.
    
    Fix this by checking whether 'pixclock' is zero in s3fb_check_var().
    
    The following log reveals it:
     divide error: 0000 [#1] PREEMPT SMP KASAN PTI
     RIP: 0010:s3fb_check_var+0x3f3/0x530
     Call Trace:
      <TASK>
      fb_set_var+0x367/0xeb0
      do_fb_ioctl+0x234/0x670
      fb_ioctl+0xdd/0x130
      do_syscall_64+0x3b/0x90
    Signed-off-by: default avatarZheyu Ma <zheyuma97@gmail.com>
    Signed-off-by: default avatarHelge Deller <deller@gmx.de>
    7015bb57
s3fb.c 44.3 KB