• Hebbar Gururaja's avatar
    ARM: OMAP2: am33xx-hwmod: Fix "register offset NULL check" bug · 169c82a2
    Hebbar Gururaja authored
    am33xx_cm_wait_module_ready() checks if register offset is NULL.
    
    int am33xx_cm_wait_module_ready(u16 inst, s16 cdoffs, u16 clkctrl_offs)
    {
    	int i = 0;
    
    	if (!clkctrl_offs)
    		return 0;
    
    In case of AM33xx, CLKCTRL register offset for different clock domains
    are not uniformly placed. An example of this would be the RTC clock
    domain with CLKCTRL offset at 0x00.
    In such cases the module ready check is skipped which leads to a data
    abort during boot-up when RTC registers is accessed.
    
    Remove this check here to avoid checking module readiness for modules
    with clkctrl register offset at 0x00.
    
    Koen Kooi notes that this patch fixes a crash on boot with
    CONFIG_RTC_DRV_OMAP=y with v3.8-rc5.
    Signed-off-by: default avatarHebbar Gururaja <gururaja.hebbar@ti.com>
    Cc: Koen Kooi <koen@dominion.thruhere.net>
    [paul@pwsan.com: noted Koen's test in the patch description]
    Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
    169c82a2
cm33xx.c 10.2 KB