• Kai Huang's avatar
    KVM, x86/mmu: Fix the comment around kvm_tdp_mmu_zap_leafs() · 7edc3a68
    Kai Huang authored
    Now kvm_tdp_mmu_zap_leafs() only zaps leaf SPTEs but not any non-root
    pages within that GFN range anymore, so the comment around it isn't
    right.
    
    Fix it by shifting the comment from tdp_mmu_zap_leafs() instead of
    duplicating it, as tdp_mmu_zap_leafs() is static and is only called by
    kvm_tdp_mmu_zap_leafs().
    
    Opportunistically tweak the blurb about SPTEs being cleared to (a) say
    "zapped" instead of "cleared" because "cleared" will be wrong if/when
    KVM allows a non-zero value for non-present SPTE (i.e. for Intel TDX),
    and (b) to clarify that a flush is needed if and only if a SPTE has been
    zapped since MMU lock was last acquired.
    
    Fixes: f47e5bbb ("KVM: x86/mmu: Zap only TDP MMU leafs in zap range and mmu_notifier unmap")
    Suggested-by: default avatarSean Christopherson <seanjc@google.com>
    Reviewed-by: default avatarSean Christopherson <seanjc@google.com>
    Signed-off-by: default avatarKai Huang <kai.huang@intel.com>
    Message-Id: <20220728030452.484261-1-kai.huang@intel.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    7edc3a68
tdp_mmu.c 57 KB