• Sean Christopherson's avatar
    Revert "KVM: x86: always allow host-initiated writes to PMU MSRs" · 545feb96
    Sean Christopherson authored
    Revert the hack to allow host-initiated accesses to all "PMU" MSRs,
    as intel_is_valid_msr() returns true for _all_ MSRs, regardless of whether
    or not it has a snowball's chance in hell of actually being a PMU MSR.
    
    That mostly gets papered over by the actual get/set helpers only handling
    MSRs that they knows about, except there's the minor detail that
    kvm_pmu_{g,s}et_msr() eat reads and writes when the PMU is disabled.
    I.e. KVM will happy allow reads and writes to _any_ MSR if the PMU is
    disabled, either via module param or capability.
    
    This reverts commit d1c88a40.
    
    Fixes: d1c88a40 ("KVM: x86: always allow host-initiated writes to PMU MSRs")
    Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
    Message-Id: <20220611005755.753273-5-seanjc@google.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    545feb96
pmu.c 16.8 KB