• Sumeet Pawnikar's avatar
    thermal: core: Increase maximum number of trip points · 82b1ec79
    Sumeet Pawnikar authored
    On one of the Chrome system, if we define more than 12 trip points,
    probe for thermal sensor fails with
    "int3403 thermal: probe of INTC1046:03 failed with error -22"
    and throws an error as
    "thermal_sys: Error: Incorrect number of thermal trips".
    
    The thermal_zone_device_register() interface needs maximum
    number of trip points supported in a zone as an argument.
    This number can't exceed THERMAL_MAX_TRIPS, which is currently
    set to 12. To address this issue, THERMAL_MAX_TRIPS value
    has to be increased.
    
    This interface also has an argument to specify a mask of trips
    which are writable. This mask is defined as an int.
    This mask sets the ceiling for increasing maximum number of
    supported trips. With the current implementation, maximum number
    of trips can be supported is 31.
    
    Also, THERMAL_MAX_TRIPS macro is used in one place only.
    So, remove THERMAL_MAX_TRIPS macro and compare num_trips
    directly with using a macro BITS_PER_TYPE(int)-1.
    Signed-off-by: default avatarSumeet Pawnikar <sumeet.r.pawnikar@intel.com>
    Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    82b1ec79
thermal_core.c 38.7 KB