• Ravi Bangoria's avatar
    perf annotate: Do not ignore call instruction with indirect target · 88a7fcf9
    Ravi Bangoria authored
    Do not ignore call instruction with indirect target when its already
    identified as a call. This is an extension of commit e8ea1561 ("perf
    annotate: Use raw form for register indirect call instructions") to
    generalize annotation for all instructions with indirect calls.
    
    This is needed for certain powerpc call instructions that use address in
    a register (such as bctrl, btarl, ...).
    
    Apart from that, when kcore is used to disassemble function, all call
    instructions were ignored. This patch will fix it as a side effect by
    not ignoring them. For example,
    
    Before (with kcore):
           mov    %r13,%rdi
           callq  0xffffffff811a7e70
         ^ jmpq   64
           mov    %gs:0x7ef41a6e(%rip),%al
    
    After (with kcore):
           mov    %r13,%rdi
         > callq  0xffffffff811a7e70
         ^ jmpq   64
           mov    %gs:0x7ef41a6e(%rip),%al
    Suggested-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    [Suggested about 'bctrl' instruction]
    Signed-off-by: default avatarRavi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Chris Riyder <chris.ryder@arm.com>
    Cc: Hemant Kumar <hemant@linux.vnet.ibm.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Markus Trippelsdorf <markus@trippelsdorf.de>
    Cc: Masami Hiramatsu <mhiramat@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
    Cc: Pawel Moll <pawel.moll@arm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Russell King <rmk+kernel@arm.linux.org.uk>
    Cc: Taeung Song <treeze.taeung@gmail.com>
    Link: http://lkml.kernel.org/r/1471611578-11255-5-git-send-email-ravi.bangoria@linux.vnet.ibm.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    88a7fcf9
annotate.c 41.9 KB