• Jinjie Ruan's avatar
    net: microchip: sparx5: Fix possible memory leak in vcap_api_encode_rule_test() · 89e3af02
    Jinjie Ruan authored
    Inject fault while probing kunit-example-test.ko, the duprule which
    is allocated in vcap_dup_rule() and the vcap enabled port which
    is allocated in vcap_enable() of vcap_enable_lookups in
    vcap_api_encode_rule_test() is not freed, and it cause the memory
    leaks below.
    
    Use vcap_enable_lookups() with false arg to free the vcap enabled
    port as other drivers do it. And use vcap_del_rule() to
    free the duprule.
    
    unreferenced object 0xffff677a0278bb00 (size 64):
      comm "kunit_try_catch", pid 388, jiffies 4294895987 (age 1101.840s)
      hex dump (first 32 bytes):
        18 bd a5 82 00 80 ff ff 18 bd a5 82 00 80 ff ff  ................
        40 fe c8 0e be c6 ff ff 00 00 00 00 00 00 00 00  @...............
      backtrace:
        [<000000007d53023a>] slab_post_alloc_hook+0xb8/0x368
        [<0000000076e3f654>] __kmem_cache_alloc_node+0x174/0x290
        [<0000000034d76721>] kmalloc_trace+0x40/0x164
        [<00000000013380a5>] vcap_enable_lookups+0x1c8/0x70c
        [<00000000bbec496b>] vcap_api_encode_rule_test+0x2f8/0xb18
        [<000000002c2bfb7b>] kunit_try_run_case+0x50/0xac
        [<00000000ff74642b>] kunit_generic_run_threadfn_adapter+0x20/0x2c
        [<000000004af845ca>] kthread+0x124/0x130
        [<0000000038a000ca>] ret_from_fork+0x10/0x20
    unreferenced object 0xffff677a027803c0 (size 192):
      comm "kunit_try_catch", pid 388, jiffies 4294895988 (age 1101.836s)
      hex dump (first 32 bytes):
        00 12 7a 00 05 00 00 00 0a 00 00 00 64 00 00 00  ..z.........d...
        00 00 00 00 00 00 00 00 d8 03 78 02 7a 67 ff ff  ..........x.zg..
      backtrace:
        [<000000007d53023a>] slab_post_alloc_hook+0xb8/0x368
        [<0000000076e3f654>] __kmem_cache_alloc_node+0x174/0x290
        [<0000000034d76721>] kmalloc_trace+0x40/0x164
        [<00000000c1010131>] vcap_dup_rule+0x34/0x14c
        [<00000000d43c54a4>] vcap_add_rule+0x29c/0x32c
        [<0000000073f1c26d>] vcap_api_encode_rule_test+0x304/0xb18
        [<000000002c2bfb7b>] kunit_try_run_case+0x50/0xac
        [<00000000ff74642b>] kunit_generic_run_threadfn_adapter+0x20/0x2c
        [<000000004af845ca>] kthread+0x124/0x130
        [<0000000038a000ca>] ret_from_fork+0x10/0x20
    
    Fixes: c956b9b3 ("net: microchip: sparx5: Adding KUNIT tests of key/action values in VCAP API")
    Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    89e3af02
vcap_api_kunit.c 67.5 KB