• Paolo Bonzini's avatar
    KVM: x86/mmu: simplify kvm_tdp_mmu_map flow when guest has to retry · 63d28a25
    Paolo Bonzini authored
    A removed SPTE is never present, hence the "if" in kvm_tdp_mmu_map
    only fails in the exact same conditions that the earlier loop
    tested in order to issue a  "break". So, instead of checking twice the
    condition (upper level SPTEs could not be created or was frozen), just
    exit the loop with a goto---the usual poor-man C replacement for RAII
    early returns.
    
    While at it, do not use the "ret" variable for return values of
    functions that do not return a RET_PF_* enum.  This is clearer
    and also makes it possible to initialize ret to RET_PF_RETRY.
    Suggested-by: default avatarRobert Hoo <robert.hu@linux.intel.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    63d28a25
tdp_mmu.c 57.2 KB