• Jason Gunthorpe's avatar
    vfio/mdev: Correct the function signatures for the mdev_type_attributes · 9169cff1
    Jason Gunthorpe authored
    The driver core standard is to pass in the properly typed object, the
    properly typed attribute and the buffer data. It stems from the root
    kobject method:
    
      ssize_t (*show)(struct kobject *kobj, struct kobj_attribute *attr,..)
    
    Each subclass of kobject should provide their own function with the same
    signature but more specific types, eg struct device uses:
    
      ssize_t (*show)(struct device *dev, struct device_attribute *attr,..)
    
    In this case the existing signature is:
    
      ssize_t (*show)(struct kobject *kobj, struct device *dev,..)
    
    Where kobj is a 'struct mdev_type *' and dev is 'mdev_type->parent->dev'.
    
    Change the mdev_type related sysfs attribute functions to:
    
      ssize_t (*show)(struct mdev_type *mtype, struct mdev_type_attribute *attr,..)
    
    In order to restore type safety and match the driver core standard
    
    There are no current users of 'attr', but if it is ever needed it would be
    hard to add in retroactively, so do it now.
    Reviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
    Reviewed-by: default avatarCornelia Huck <cohuck@redhat.com>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
    Message-Id: <18-v2-d36939638fc6+d54-vfio2_jgg@nvidia.com>
    Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
    9169cff1
mtty.c 32.2 KB