• Darrick J. Wong's avatar
    Merge tag 'xfs-delay-ready-attrs-v20.1' of... · d1015e2e
    Darrick J. Wong authored
    Merge tag 'xfs-delay-ready-attrs-v20.1' of https://github.com/allisonhenderson/xfs_work into xfs-5.14-merge4
    
    xfs: Delay Ready Attributes
    
    Hi all,
    
    This set is a subset of a larger series for Dealyed Attributes. Which is a
    subset of a yet larger series for parent pointers. Delayed attributes allow
    attribute operations (set and remove) to be logged and committed in the same
    way that other delayed operations do. This allows more complex operations (like
    parent pointers) to be broken up into multiple smaller transactions. To do
    this, the existing attr operations must be modified to operate as a delayed
    operation.  This means that they cannot roll, commit, or finish transactions.
    Instead, they return -EAGAIN to allow the calling function to handle the
    transaction.  In this series, we focus on only the delayed attribute portion.
    We will introduce parent pointers in a later set.
    
    The set as a whole is a bit much to digest at once, so I usually send out the
    smaller sub series to reduce reviewer burn out.  But the entire extended series
    is visible through the included github links.
    
    Updates since v19: Added Darricks fix for the remote block accounting as well as
    some minor nits about the default assert in xfs_attr_set_iter.  Spent quite
    a bit of time testing this cycle to weed out any more unexpected bugs.  No new
    test failures were observed with the addition of this set.
    
    xfs: Fix default ASSERT in xfs_attr_set_iter
      Replaced the assert with ASSERT(0);
    
    xfs: Add delay ready attr remove routines
      Added Darricks fix for remote block accounting
    
    This series can be viewed on github here:
    https://github.com/allisonhenderson/xfs_work/tree/delay_ready_attrs_v20
    
    As well as the extended delayed attribute and parent pointer series:
    https://github.com/allisonhenderson/xfs_work/tree/delay_ready_attrs_v20_extended
    
    And the test cases:
    https://github.com/allisonhenderson/xfs_work/tree/pptr_xfstestsv3
    In order to run the test cases, you will need have the corresponding xfsprogs
    
    changes as well.  Which can be found here:
    https://github.com/allisonhenderson/xfs_work/tree/delay_ready_attrs_xfsprogs_v20
    https://github.com/allisonhenderson/xfs_work/tree/delay_ready_attrs_xfsprogs_v20_extended
    
    To run the xfs attributes tests run:
    check -g attr
    
    To run as delayed attributes run:
    export MOUNT_OPTIONS="-o delattr"
    check -g attr
    
    To run parent pointer tests:
    check -g parent
    
    I've also made the corresponding updates to the user space side as well, and ported anything
    they need to seat correctly.
    
    Questions, comment and feedback appreciated!
    
    Thanks all!
    Allison
    
    * tag 'xfs-delay-ready-attrs-v20.1' of https://github.com/allisonhenderson/xfs_work:
      xfs: Make attr name schemes consistent
      xfs: Fix default ASSERT in xfs_attr_set_iter
      xfs: Clean up xfs_attr_node_addname_clear_incomplete
      xfs: Remove xfs_attr_rmtval_set
      xfs: Add delay ready attr set routines
      xfs: Add delay ready attr remove routines
      xfs: Hoist node transaction handling
      xfs: Hoist xfs_attr_leaf_addname
      xfs: Hoist xfs_attr_node_addname
      xfs: Add helper xfs_attr_node_addname_find_attr
      xfs: Separate xfs_attr_node_addname and xfs_attr_node_addname_clear_incomplete
      xfs: Refactor xfs_attr_set_shortform
      xfs: Add xfs_attr_node_remove_name
      xfs: Reverse apply 72b97ea4
    d1015e2e
xfs_attr_leaf.c 83.2 KB