• Yunsheng Lin's avatar
    rxrpc: Fix using alignmask being zero for __page_frag_alloc_align() · 9f8eeea1
    Yunsheng Lin authored
    rxrpc_alloc_data_txbuf() may be called with data_align being
    zero in none_alloc_txbuf() and rxkad_alloc_txbuf(), data_align
    is supposed to be an order-based alignment value, but zero is
    not a valid order-based alignment value, and '~(data_align - 1)'
    doesn't result in a valid mask-based alignment value for
    __page_frag_alloc_align().
    
    Fix it by passing a valid order-based alignment value in
    none_alloc_txbuf() and rxkad_alloc_txbuf().
    
    Also use page_frag_alloc_align() expecting an order-based
    alignment value in rxrpc_alloc_data_txbuf() to avoid doing the
    alignment converting operation and to catch possible invalid
    alignment value in the future. Remove the 'if (data_align)'
    checking too, as it is always true for a valid order-based
    alignment value.
    
    Fixes: 6b253646 ("rxrpc: Fix use of changed alignment param to page_frag_alloc_align()")
    Fixes: 49489bb0 ("rxrpc: Do zerocopy using MSG_SPLICE_PAGES and page frags")
    CC: Alexander Duyck <alexander.duyck@gmail.com>
    Signed-off-by: default avatarYunsheng Lin <linyunsheng@huawei.com>
    Acked-by: default avatarDavid Howells <dhowells@redhat.com>
    Link: https://lore.kernel.org/r/20240428111640.27306-1-linyunsheng@huawei.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    9f8eeea1
txbuf.c 6.13 KB