• J. Bruce Fields's avatar
    nfsd: fix oops on access from high-numbered ports · b663c6fd
    J. Bruce Fields authored
    This bug was always here, but before my commit 6fa02839
    ("recheck for secure ports in fh_verify"), it could only be triggered by
    failure of a kmalloc().  After that commit it could be triggered by a
    client making a request from a non-reserved port for access to an export
    marked "secure".  (Exports are "secure" by default.)
    
    The result is a struct svc_export with a reference count one too low,
    resulting in likely oopses next time the export is accessed.
    
    The reference counting here is not straightforward; a later patch will
    clean up fh_verify().
    
    Thanks to Lukas Hejtmanek for the bug report and followup.
    Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
    Cc: Lukas Hejtmanek <xhejtman@ics.muni.cz>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    b663c6fd
nfsfh.c 15 KB