• Ilpo Järvinen's avatar
    selftests/resctrl: Move resctrl FS mount/umount to higher level · caddc0fb
    Ilpo Järvinen authored
    A few places currently lack umounting resctrl FS on error paths:
      - cmt_resctrl_val() has multiple error paths with direct return.
      - cat_perf_miss_val() has multiple error paths with direct return.
    In addition, validate_resctrl_feature_request() is called by
    run_mbm_test() and run_mba_test(). Neither MBA nor MBM test tries to
    umount resctrl FS.
    
    Each and every test does require resctrl FS to be present already for
    feature check. Thus, it makes sense to just mount it on higher level in
    resctrl_tests.c and properly pair it with umount.
    
    Move resctrl FS (re)mount/unmount into each test function in
    resctrl_tests.c. Make feature validation to simply check that resctrl
    FS is mounted.
    
    As there's the final umount in main() before this change, the selftest
    should not leave resctrl FS behind after the tests even if one of the
    forementioned paths is taken (thus, no fixes tag).
    Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
    Tested-by: default avatarBabu Moger <babu.moger@amd.com>
    Tested-by: default avatarShaopeng Tan (Fujitsu) <tan.shaopeng@fujitsu.com>
    Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
    caddc0fb
resctrl_tests.c 7.21 KB