• John David Anglin's avatar
    Revert "parisc: Re-enable interrupts early" · 9352aead
    John David Anglin authored
    This reverts commit 5c38602d.
    
    Interrupts can't be enabled early because the register saves are done on
    the thread stack prior to switching to the IRQ stack.  This caused stack
    overflows and the thread stack needed increasing to 32k.  Even then,
    stack overflows still occasionally occurred.
    
    Background:
    Even with a 32 kB thread stack, I have seen instances where the thread
    stack overflowed on the mx3210 buildd.  Detection of stack overflow only
    occurs when we have an external interrupt.  When an external interrupt
    occurs, we switch to the thread stack if we are not already on a kernel
    stack.  Then, registers and specials are saved to the kernel stack.
    
    The bug occurs in intr_return where interrupts are reenabled prior to
    returning from the interrupt.  This was done incase we need to schedule
    or deliver signals.  However, it introduces the possibility that
    multiple external interrupts may occur on the thread stack and cause a
    stack overflow.  These might not be detected and cause the kernel to
    misbehave in random ways.
    
    This patch changes the code back to only reenable interrupts when we are
    going to schedule or deliver signals.  As a result, we generally return
    from an interrupt before reenabling interrupts.  This minimizes the
    growth of the thread stack.
    
    Fixes: 5c38602d ("parisc: Re-enable interrupts early")
    Signed-off-by: default avatarJohn David Anglin <dave.anglin@bell.net>
    Cc: <stable@vger.kernel.org> # v4.10+
    Signed-off-by: default avatarHelge Deller <deller@gmx.de>
    9352aead
entry.S 53.5 KB