• Qu Wenruo's avatar
    btrfs: trigger orphan inode cleanup during START_SYNC ioctl · edc72881
    Qu Wenruo authored
    There is an internal error report that scrub found an error in an orphan
    inode's data.
    
    However there are very limited ways to cleanup such orphan inodes:
    
    - btrfs_start_pre_rw_mount()
      This happens at either mount, or RO->RW switch.
      This is not a viable solution for root fs which may not be unmounted
      or RO mounted.
    
      Furthermore this doesn't cover every subvolume, it only covers the
      currently cached subvolumes.
    
    - btrfs_lookup_dentry()
      This happens when we first lookup the subvolume dentry.
      But dentry can be cached thus it's not ensured to be triggered every
      time.
    
    - create_snapshot()
      This only happens for the created snapshot, not the source one.
    
    This means if we didn't trigger orphan items cleanup, there is really no
    other way to manually trigger it. Add this step to the START_SYNC ioctl.
    This is a slight change in the semantics of the ioctl but as sync can be
    potentially slow and is usually paired with WAIT_SYNC ioctl.
    
    The errors are not handled because the main point of the ioctl is the
    async commit, orphan cleanup is a side effect.
    Signed-off-by: default avatarQu Wenruo <wqu@suse.com>
    Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    edc72881
ioctl.c 116 KB