• Douglas Anderson's avatar
    drm/panel: Move AUX B116XW03 out of panel-edp back to panel-simple · ad3e33fe
    Douglas Anderson authored
    In commit 5f04e7ce ("drm/panel-edp: Split eDP panels out of
    panel-simple") I moved a pile of panels out of panel-simple driver
    into the newly created panel-edp driver. One of those panels, however,
    shouldn't have been moved.
    
    As is clear from commit e35e305e ("drm/panel: simple: Add AUO
    B116XW03 panel support"), AUX B116XW03 is an LVDS panel. It's used in
    exynos5250-snow and exynos5420-peach-pit where it's clear that the
    panel is hooked up with LVDS. Furthermore, searching for datasheets I
    found one that makes it clear that this panel is LVDS.
    
    As far as I can tell, I got confused because in commit 88d3457c
    ("drm/panel: auo,b116xw03: fix flash backlight when power on") Jitao
    Shi added "DRM_MODE_CONNECTOR_eDP". That seems wrong. Looking at the
    downstream ChromeOS trees, it seems like some Mediatek boards are
    using a panel that they call "auo,b116xw03" that's an eDP panel. The
    best I can guess is that they actually have a different panel that has
    similar timing. If so then the proper panel should be used or they
    should switch to the generic "edp-panel" compatible.
    
    When moving this back to panel-edp, I wasn't sure what to use for
    .bus_flags and .bus_format and whether to add the extra "enable" delay
    from commit 88d3457c ("drm/panel: auo,b116xw03: fix flash
    backlight when power on"). I've added formats/flags/delays based on my
    (inexpert) analysis of the datasheet. These are untested.
    
    NOTE: if/when this is backported to stable, we might run into some
    trouble. Specifically, before 474c1628 ("arm64: dts: mt8183:
    jacuzzi: Move panel under aux-bus") this panel was used by
    "mt8183-kukui-jacuzzi", which assumed it was an eDP panel. I don't
    know what to suggest for that other than someone making up a bogus
    panel for jacuzzi that's just for the stable channel.
    
    Fixes: 88d3457c ("drm/panel: auo,b116xw03: fix flash backlight when power on")
    Fixes: 5f04e7ce ("drm/panel-edp: Split eDP panels out of panel-simple")
    Tested-by: default avatarAnton Bambura <jenneron@postmarketos.org>
    Acked-by: default avatarHsin-Yi Wang <hsinyi@chromium.org>
    Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
    Link: https://patchwork.freedesktop.org/patch/msgid/20230925150010.1.Iff672233861bcc4cf25a7ad0a81308adc3bda8a4@changeid
    ad3e33fe
panel-simple.c 120 KB