• Julia Lawall's avatar
    ASoC: intel: broadwell: constify snd_soc_ops structures · d5bc18c1
    Julia Lawall authored
    Check for snd_soc_ops structures that are only stored in the ops field of a
    snd_soc_dai_link structure.  This field is declared const, so snd_soc_ops
    structures that have this property can be declared as const also.
    
    The semantic patch that makes this change is as follows:
    (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @r disable optional_qualifier@
    identifier i;
    position p;
    @@
    static struct snd_soc_ops i@p = { ... };
    
    @ok1@
    identifier r.i;
    struct snd_soc_dai_link e;
    position p;
    @@
    e.ops = &i@p;
    
    @ok2@
    identifier r.i, e;
    position p;
    @@
    struct snd_soc_dai_link e[] = { ..., { .ops = &i@p, }, ..., };
    
    @bad@
    position p != {r.p,ok1.p,ok2.p};
    identifier r.i;
    struct snd_soc_ops e;
    @@
    e@i@p
    
    @depends on !bad disable optional_qualifier@
    identifier r.i;
    @@
    static
    +const
     struct snd_soc_ops i = { ... };
    // </smpl>
    
    The effect on the layout of the .o file is shown by the following output of
    the size command, first before then after the transformation:
    
       text    data     bss     dec     hex filename
       3865    2784     384    7033    1b79 sound/soc/intel/boards/broadwell.o
       3929    2720     384    7033    1b79 sound/soc/intel/boards/broadwell.o
    Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
    Acked-by: default avatarJie Yang <yang.jie@intel.com>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    d5bc18c1
broadwell.c 7.63 KB