• Sebastian Andrzej Siewior's avatar
    hsr: Disable netpoll. · d5c7652e
    Sebastian Andrzej Siewior authored
    The hsr device is a software device. Its
    net_device_ops::ndo_start_xmit() routine will process the packet and
    then pass the resulting skb to dev_queue_xmit().
    During processing, hsr acquires a lock with spin_lock_bh()
    (hsr_add_node()) which needs to be promoted to the _irq() suffix in
    order to avoid a potential deadlock.
    Then there are the warnings in dev_queue_xmit() (due to
    local_bh_disable() with disabled interrupts) left.
    
    Instead trying to address those (there is qdisc and…) for netpoll sake,
    just disable netpoll on hsr.
    
    Disable netpoll on hsr and replace the _irqsave() locking with _bh().
    
    Fixes: f421436a ("net/hsr: Add support for the High-availability Seamless Redundancy protocol (HSRv0)")
    Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    d5c7652e
hsr_device.c 13.7 KB