• Milton Miller's avatar
    hvc_console: Do not set low_latency when using interrupts · da9dc132
    Milton Miller authored
    hvc_console is setting low_latency unconditionally, but some clients are
    interrupt driven and will call hvc_poll from irq context.  This will cause
    tty_flip_buffer_push to be called from irq context, and it very clearly
    states it must not be called from IRQ when low_latency is specified.
    
    Looking back through history:
    v2.6.16-rc1 via 33f0f88f
        [PATCH] TTY layer buffering revamp
    
    added this new api.
    
    v2.6.16-rc3 via 8977d929
        [PATCH] tty buffering stall fix
    
    claims to fix a stall discovered with hvc_console
    
    v2.6.16-rc5 via fb5c594c
       [PATCH] Fix race condition in hvc console.
    
    said set this flag to avoid a stall problem, and was merged through
    the powerpc arch tree.
    
    Without searching for email discussions, it would appear to be an
    overlapping "fix", but one that did not consider all users.
    Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
    da9dc132
hvc_console.c 21.9 KB