• Colin Ian King's avatar
    ASoC: qcom: Fix uninitialized pointer dmactl · 1382d8b5
    Colin Ian King authored
    In the case where __lpass_get_dmactl_handle is called and the driver
    id dai_id is invalid the pointer dmactl is not being assigned a value,
    and dmactl contains a garbage value since it has not been initialized
    and so the null check may not work. Fix this to initialize dmactl to
    NULL. One could argue that modern compilers will set this to zero, but
    it is useful to keep this initialized as per the same way in functions
    __lpass_platform_codec_intf_init and lpass_cdc_dma_daiops_hw_params.
    
    Cleans up clang scan build warning:
    sound/soc/qcom/lpass-cdc-dma.c:275:7: warning: Branch condition
    evaluates to a garbage value [core.uninitialized.Branch]
    
    Fixes: b81af585 ("ASoC: qcom: Add lpass CPU driver for codec dma control")
    Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
    Link: https://msgid.link/r/20240221134804.3475989-1-colin.i.king@gmail.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    1382d8b5
lpass-cdc-dma.c 8.26 KB