Commit 038dab7e authored by Markus Elfring's avatar Markus Elfring Committed by David S. Miller

can: Delete unnecessary checks before the macro call “dev_kfree_skb”

The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the shown calls is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Acked-by: default avatarSean Nyekjaer <sean@geanix.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0f817a5e
...@@ -177,8 +177,7 @@ static void hi3110_clean(struct net_device *net) ...@@ -177,8 +177,7 @@ static void hi3110_clean(struct net_device *net)
if (priv->tx_skb || priv->tx_len) if (priv->tx_skb || priv->tx_len)
net->stats.tx_errors++; net->stats.tx_errors++;
if (priv->tx_skb) dev_kfree_skb(priv->tx_skb);
dev_kfree_skb(priv->tx_skb);
if (priv->tx_len) if (priv->tx_len)
can_free_echo_skb(priv->net, 0); can_free_echo_skb(priv->net, 0);
priv->tx_skb = NULL; priv->tx_skb = NULL;
......
...@@ -264,8 +264,7 @@ static void mcp251x_clean(struct net_device *net) ...@@ -264,8 +264,7 @@ static void mcp251x_clean(struct net_device *net)
if (priv->tx_skb || priv->tx_len) if (priv->tx_skb || priv->tx_len)
net->stats.tx_errors++; net->stats.tx_errors++;
if (priv->tx_skb) dev_kfree_skb(priv->tx_skb);
dev_kfree_skb(priv->tx_skb);
if (priv->tx_len) if (priv->tx_len)
can_free_echo_skb(priv->net, 0); can_free_echo_skb(priv->net, 0);
priv->tx_skb = NULL; priv->tx_skb = NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment