Commit 0870b0d8 authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski

net: busy-poll: use ktime_get_ns() instead of local_clock()

Typically, busy-polling durations are below 100 usec.

When/if the busy-poller thread migrates to another cpu,
local_clock() can be off by +/-2msec or more for small
values of HZ, depending on the platform.

Use ktimer_get_ns() to ensure deterministic behavior,
which is the whole point of busy-polling.

Fixes: 06021292 ("net: add low latency socket poll")
Fixes: 9a3c71aa ("net: convert low latency sockets to sched_clock()")
Fixes: 37089834 ("sched, net: Fixup busy_loop_us_clock()")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Mina Almasry <almasrymina@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Reviewed-by: default avatarJoe Damato <jdamato@fastly.com>
Link: https://patch.msgid.link/20240827114916.223377-1-edumazet@google.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 41901c22
...@@ -68,7 +68,7 @@ static inline bool sk_can_busy_loop(struct sock *sk) ...@@ -68,7 +68,7 @@ static inline bool sk_can_busy_loop(struct sock *sk)
static inline unsigned long busy_loop_current_time(void) static inline unsigned long busy_loop_current_time(void)
{ {
#ifdef CONFIG_NET_RX_BUSY_POLL #ifdef CONFIG_NET_RX_BUSY_POLL
return (unsigned long)(local_clock() >> 10); return (unsigned long)(ktime_get_ns() >> 10);
#else #else
return 0; return 0;
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment