Commit 1123c514 authored by Guenter Roeck's avatar Guenter Roeck Committed by Wim Van Sebroeck

watchdog: it87: Use infrastructure to stop watchdog on reboot

Use watchdog_stop_on_reboot() to stop the watchdog on reboot instead
of registering a driver-specific notifier.

While at it, reorder remaining include files alphabetically.
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
parent 893dc8b5
...@@ -28,15 +28,13 @@ ...@@ -28,15 +28,13 @@
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/init.h>
#include <linux/io.h>
#include <linux/kernel.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/moduleparam.h> #include <linux/moduleparam.h>
#include <linux/types.h> #include <linux/types.h>
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/watchdog.h> #include <linux/watchdog.h>
#include <linux/notifier.h>
#include <linux/reboot.h>
#include <linux/io.h>
#define WATCHDOG_NAME "IT87 WDT" #define WATCHDOG_NAME "IT87 WDT"
...@@ -260,18 +258,6 @@ static struct watchdog_device wdt_dev = { ...@@ -260,18 +258,6 @@ static struct watchdog_device wdt_dev = {
.min_timeout = 1, .min_timeout = 1,
}; };
static int wdt_notify_sys(struct notifier_block *this, unsigned long code,
void *unused)
{
if (code == SYS_DOWN || code == SYS_HALT)
wdt_stop(&wdt_dev);
return NOTIFY_DONE;
}
static struct notifier_block wdt_notifier = {
.notifier_call = wdt_notify_sys,
};
static int __init it87_wdt_init(void) static int __init it87_wdt_init(void)
{ {
u8 chip_rev; u8 chip_rev;
...@@ -338,32 +324,22 @@ static int __init it87_wdt_init(void) ...@@ -338,32 +324,22 @@ static int __init it87_wdt_init(void)
wdt_dev.timeout = timeout; wdt_dev.timeout = timeout;
wdt_dev.max_timeout = max_units * 60; wdt_dev.max_timeout = max_units * 60;
rc = register_reboot_notifier(&wdt_notifier); watchdog_stop_on_reboot(&wdt_dev);
if (rc) {
pr_err("Cannot register reboot notifier (err=%d)\n", rc);
return rc;
}
rc = watchdog_register_device(&wdt_dev); rc = watchdog_register_device(&wdt_dev);
if (rc) { if (rc) {
pr_err("Cannot register watchdog device (err=%d)\n", rc); pr_err("Cannot register watchdog device (err=%d)\n", rc);
goto err_out_reboot; return rc;
} }
pr_info("Chip IT%04x revision %d initialized. timeout=%d sec (nowayout=%d testmode=%d)\n", pr_info("Chip IT%04x revision %d initialized. timeout=%d sec (nowayout=%d testmode=%d)\n",
chip_type, chip_rev, timeout, nowayout, testmode); chip_type, chip_rev, timeout, nowayout, testmode);
return 0; return 0;
err_out_reboot:
unregister_reboot_notifier(&wdt_notifier);
return rc;
} }
static void __exit it87_wdt_exit(void) static void __exit it87_wdt_exit(void)
{ {
watchdog_unregister_device(&wdt_dev); watchdog_unregister_device(&wdt_dev);
unregister_reboot_notifier(&wdt_notifier);
} }
module_init(it87_wdt_init); module_init(it87_wdt_init);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment