Commit 199b2bc2 authored by Ben Widawsky's avatar Ben Widawsky Committed by Daniel Vetter

drm/i915: s/i915_wait_request/i915_wait_seqno/g

Wait request is poorly named IMO. After working with these functions for
some time, I feel it's much clearer to name the functions more
appropriately.

Of course we must update the callers to use the new name as well.

This leaves room within our namespace for a *real* wait request function
at some point.

Note to maintainer: this patch is optional.
Signed-off-by: default avatarBen Widawsky <ben@bwidawsk.net>
Reviewed-by: default avatarEugeni Dodonov <eugeni.dodonov@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 23ba4fd0
...@@ -1315,7 +1315,7 @@ int __must_check i915_gem_idle(struct drm_device *dev); ...@@ -1315,7 +1315,7 @@ int __must_check i915_gem_idle(struct drm_device *dev);
int __must_check i915_add_request(struct intel_ring_buffer *ring, int __must_check i915_add_request(struct intel_ring_buffer *ring,
struct drm_file *file, struct drm_file *file,
struct drm_i915_gem_request *request); struct drm_i915_gem_request *request);
int __must_check i915_wait_request(struct intel_ring_buffer *ring, int __must_check i915_wait_seqno(struct intel_ring_buffer *ring,
uint32_t seqno); uint32_t seqno);
int i915_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf); int i915_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf);
int __must_check int __must_check
......
...@@ -1952,8 +1952,7 @@ static int __wait_seqno(struct intel_ring_buffer *ring, u32 seqno, ...@@ -1952,8 +1952,7 @@ static int __wait_seqno(struct intel_ring_buffer *ring, u32 seqno,
* request and object lists appropriately for that event. * request and object lists appropriately for that event.
*/ */
int int
i915_wait_request(struct intel_ring_buffer *ring, i915_wait_seqno(struct intel_ring_buffer *ring, uint32_t seqno)
uint32_t seqno)
{ {
drm_i915_private_t *dev_priv = ring->dev->dev_private; drm_i915_private_t *dev_priv = ring->dev->dev_private;
int ret = 0; int ret = 0;
...@@ -1991,7 +1990,7 @@ i915_gem_object_wait_rendering(struct drm_i915_gem_object *obj) ...@@ -1991,7 +1990,7 @@ i915_gem_object_wait_rendering(struct drm_i915_gem_object *obj)
* it. * it.
*/ */
if (obj->active) { if (obj->active) {
ret = i915_wait_request(obj->ring, obj->last_rendering_seqno); ret = i915_wait_seqno(obj->ring, obj->last_rendering_seqno);
if (ret) if (ret)
return ret; return ret;
i915_gem_retire_requests_ring(obj->ring); i915_gem_retire_requests_ring(obj->ring);
...@@ -2264,7 +2263,7 @@ static int i915_ring_idle(struct intel_ring_buffer *ring) ...@@ -2264,7 +2263,7 @@ static int i915_ring_idle(struct intel_ring_buffer *ring)
return ret; return ret;
} }
return i915_wait_request(ring, i915_gem_next_request_seqno(ring)); return i915_wait_seqno(ring, i915_gem_next_request_seqno(ring));
} }
int i915_gpu_idle(struct drm_device *dev) int i915_gpu_idle(struct drm_device *dev)
...@@ -2468,7 +2467,7 @@ i915_gem_object_flush_fence(struct drm_i915_gem_object *obj) ...@@ -2468,7 +2467,7 @@ i915_gem_object_flush_fence(struct drm_i915_gem_object *obj)
} }
if (obj->last_fenced_seqno) { if (obj->last_fenced_seqno) {
ret = i915_wait_request(obj->ring, obj->last_fenced_seqno); ret = i915_wait_seqno(obj->ring, obj->last_fenced_seqno);
if (ret) if (ret)
return ret; return ret;
......
...@@ -226,7 +226,7 @@ static int intel_overlay_do_wait_request(struct intel_overlay *overlay, ...@@ -226,7 +226,7 @@ static int intel_overlay_do_wait_request(struct intel_overlay *overlay,
} }
overlay->last_flip_req = request->seqno; overlay->last_flip_req = request->seqno;
overlay->flip_tail = tail; overlay->flip_tail = tail;
ret = i915_wait_request(ring, overlay->last_flip_req); ret = i915_wait_seqno(ring, overlay->last_flip_req);
if (ret) if (ret)
return ret; return ret;
i915_gem_retire_requests(dev); i915_gem_retire_requests(dev);
...@@ -452,7 +452,7 @@ static int intel_overlay_recover_from_interrupt(struct intel_overlay *overlay) ...@@ -452,7 +452,7 @@ static int intel_overlay_recover_from_interrupt(struct intel_overlay *overlay)
if (overlay->last_flip_req == 0) if (overlay->last_flip_req == 0)
return 0; return 0;
ret = i915_wait_request(ring, overlay->last_flip_req); ret = i915_wait_seqno(ring, overlay->last_flip_req);
if (ret) if (ret)
return ret; return ret;
i915_gem_retire_requests(dev); i915_gem_retire_requests(dev);
......
...@@ -1085,7 +1085,7 @@ static int intel_ring_wait_seqno(struct intel_ring_buffer *ring, u32 seqno) ...@@ -1085,7 +1085,7 @@ static int intel_ring_wait_seqno(struct intel_ring_buffer *ring, u32 seqno)
was_interruptible = dev_priv->mm.interruptible; was_interruptible = dev_priv->mm.interruptible;
dev_priv->mm.interruptible = false; dev_priv->mm.interruptible = false;
ret = i915_wait_request(ring, seqno); ret = i915_wait_seqno(ring, seqno);
dev_priv->mm.interruptible = was_interruptible; dev_priv->mm.interruptible = was_interruptible;
if (!ret) if (!ret)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment