Commit 243cfa6a authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Bartosz Golaszewski

gpiolib: Use list_first_entry()/list_last_entry()

Use list_first_entry()/list_last_entry() instead of open coded variants.
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent 37db988c
...@@ -262,14 +262,14 @@ static int gpiodev_add_to_list(struct gpio_device *gdev) ...@@ -262,14 +262,14 @@ static int gpiodev_add_to_list(struct gpio_device *gdev)
return 0; return 0;
} }
next = list_entry(gpio_devices.next, struct gpio_device, list); next = list_first_entry(&gpio_devices, struct gpio_device, list);
if (gdev->base + gdev->ngpio <= next->base) { if (gdev->base + gdev->ngpio <= next->base) {
/* add before first entry */ /* add before first entry */
list_add(&gdev->list, &gpio_devices); list_add(&gdev->list, &gpio_devices);
return 0; return 0;
} }
prev = list_entry(gpio_devices.prev, struct gpio_device, list); prev = list_last_entry(&gpio_devices, struct gpio_device, list);
if (prev->base + prev->ngpio <= gdev->base) { if (prev->base + prev->ngpio <= gdev->base) {
/* add behind last entry */ /* add behind last entry */
list_add_tail(&gdev->list, &gpio_devices); list_add_tail(&gdev->list, &gpio_devices);
...@@ -4423,7 +4423,7 @@ static void *gpiolib_seq_next(struct seq_file *s, void *v, loff_t *pos) ...@@ -4423,7 +4423,7 @@ static void *gpiolib_seq_next(struct seq_file *s, void *v, loff_t *pos)
if (list_is_last(&gdev->list, &gpio_devices)) if (list_is_last(&gdev->list, &gpio_devices))
ret = NULL; ret = NULL;
else else
ret = list_entry(gdev->list.next, struct gpio_device, list); ret = list_first_entry(&gdev->list, struct gpio_device, list);
spin_unlock_irqrestore(&gpio_lock, flags); spin_unlock_irqrestore(&gpio_lock, flags);
s->private = "\n"; s->private = "\n";
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment