Commit 252bd125 authored by Hyeongseok Kim's avatar Hyeongseok Kim Committed by Mike Snitzer

dm verity: skip verity work if I/O error when system is shutting down

If emergency system shutdown is called, like by thermal shutdown,
a dm device could be alive when the block device couldn't process
I/O requests anymore. In this state, the handling of I/O errors
by new dm I/O requests or by those already in-flight can lead to
a verity corruption state, which is a misjudgment.

So, skip verity work in response to I/O error when system is shutting
down.
Signed-off-by: default avatarHyeongseok Kim <hyeongseok@gmail.com>
Reviewed-by: default avatarSami Tolvanen <samitolvanen@google.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
parent a2b8b2d9
...@@ -537,6 +537,15 @@ static int verity_verify_io(struct dm_verity_io *io) ...@@ -537,6 +537,15 @@ static int verity_verify_io(struct dm_verity_io *io)
return 0; return 0;
} }
/*
* Skip verity work in response to I/O error when system is shutting down.
*/
static inline bool verity_is_system_shutting_down(void)
{
return system_state == SYSTEM_HALT || system_state == SYSTEM_POWER_OFF
|| system_state == SYSTEM_RESTART;
}
/* /*
* End one "io" structure with a given error. * End one "io" structure with a given error.
*/ */
...@@ -564,7 +573,8 @@ static void verity_end_io(struct bio *bio) ...@@ -564,7 +573,8 @@ static void verity_end_io(struct bio *bio)
{ {
struct dm_verity_io *io = bio->bi_private; struct dm_verity_io *io = bio->bi_private;
if (bio->bi_status && !verity_fec_is_enabled(io->v)) { if (bio->bi_status &&
(!verity_fec_is_enabled(io->v) || verity_is_system_shutting_down())) {
verity_finish_io(io, bio->bi_status); verity_finish_io(io, bio->bi_status);
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment