Commit 2984b0dd authored by Robert Foss's avatar Robert Foss Committed by Mauro Carvalho Chehab

media: ov8856: Configure sensor for GRBG Bayer for all modes

The previously added modes 3264x2448 & 1632x1224 are actually
configuring the sensor for BGGR mode, this is an issue since
the mode that is exposed through V4L incorrectly is set as GRBG.

This patch fixes the issue by moving the output crop window of
internal sensor ISP uses by one row, which means that the Bayer
pattern of the output is changed.

row 1: B G B G B G ...
row 2: G R G R G R ...
row 3: B G B G B G ...
...

row 2: G R G R G R ...
row 3: B G B G B G ...
...
Signed-off-by: default avatarRobert Foss <robert.foss@linaro.org>
Suggested-by: default avatarAndrey Konovalov <andrey.konovalov@linaro.org>
Reviewed-by: default avatarAndrey Konovalov <andrey.konovalov@linaro.org>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 49b94d58
...@@ -428,7 +428,7 @@ static const struct ov8856_reg mode_3264x2448_regs[] = { ...@@ -428,7 +428,7 @@ static const struct ov8856_reg mode_3264x2448_regs[] = {
{0x3810, 0x00}, {0x3810, 0x00},
{0x3811, 0x04}, {0x3811, 0x04},
{0x3812, 0x00}, {0x3812, 0x00},
{0x3813, 0x02}, {0x3813, 0x01},
{0x3814, 0x01}, {0x3814, 0x01},
{0x3815, 0x01}, {0x3815, 0x01},
{0x3816, 0x00}, {0x3816, 0x00},
...@@ -821,7 +821,7 @@ static const struct ov8856_reg mode_1632x1224_regs[] = { ...@@ -821,7 +821,7 @@ static const struct ov8856_reg mode_1632x1224_regs[] = {
{0x3810, 0x00}, {0x3810, 0x00},
{0x3811, 0x02}, {0x3811, 0x02},
{0x3812, 0x00}, {0x3812, 0x00},
{0x3813, 0x02}, {0x3813, 0x01},
{0x3814, 0x03}, {0x3814, 0x03},
{0x3815, 0x01}, {0x3815, 0x01},
{0x3816, 0x00}, {0x3816, 0x00},
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment