Commit 2b448334 authored by Lennert Buytenhek's avatar Lennert Buytenhek Committed by David S. Miller

mv643xx_eth: fix multicast filter programming

Commit 66e63ffb ("mv643xx_eth:
implement ->set_rx_mode()") cleaned up mv643xx_eth's multicast filter
programming, but broke it as well.

The non-special multicast filter table (for multicast addresses that
are not of the form 01:00:5e:00:00:xx) consists of 256 hash table
buckets organised as 64 32-bit words, where the 'accept' bits are
in the LSB of each byte, so in bits 24 16 8 0 of each 32-bit word.
The old code got this right, but the referenced commit broke this by
using bits 3 2 1 0 instead.  This commit fixes this up.
Signed-off-by: default avatarLennert Buytenhek <buytenh@marvell.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e0c6ef93
...@@ -1596,7 +1596,7 @@ static void mv643xx_eth_program_multicast_filter(struct net_device *dev) ...@@ -1596,7 +1596,7 @@ static void mv643xx_eth_program_multicast_filter(struct net_device *dev)
entry = addr_crc(a); entry = addr_crc(a);
} }
table[entry >> 2] |= 1 << (entry & 3); table[entry >> 2] |= 1 << (8 * (entry & 3));
} }
for (i = 0; i < 0x100; i += 4) { for (i = 0; i < 0x100; i += 4) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment