Commit 2ef9a1e7 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Hans Verkuil

media: vimc: Don't iterate over single pad

The .init_state() operations of the debayer and sensor entities iterate
over the entity's pads. In practice, the iteration covers a single pad
only. Access the pad directly and remove the loops.
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent b6ee5ac1
...@@ -155,16 +155,13 @@ static int vimc_debayer_init_state(struct v4l2_subdev *sd, ...@@ -155,16 +155,13 @@ static int vimc_debayer_init_state(struct v4l2_subdev *sd,
{ {
struct vimc_debayer_device *vdebayer = v4l2_get_subdevdata(sd); struct vimc_debayer_device *vdebayer = v4l2_get_subdevdata(sd);
struct v4l2_mbus_framefmt *mf; struct v4l2_mbus_framefmt *mf;
unsigned int i;
mf = v4l2_subdev_state_get_format(sd_state, 0); mf = v4l2_subdev_state_get_format(sd_state, 0);
*mf = sink_fmt_default; *mf = sink_fmt_default;
for (i = 1; i < sd->entity.num_pads; i++) { mf = v4l2_subdev_state_get_format(sd_state, 1);
mf = v4l2_subdev_state_get_format(sd_state, i); *mf = sink_fmt_default;
*mf = sink_fmt_default; mf->code = vdebayer->src_code;
mf->code = vdebayer->src_code;
}
return 0; return 0;
} }
......
...@@ -44,14 +44,10 @@ static const struct v4l2_mbus_framefmt fmt_default = { ...@@ -44,14 +44,10 @@ static const struct v4l2_mbus_framefmt fmt_default = {
static int vimc_sensor_init_state(struct v4l2_subdev *sd, static int vimc_sensor_init_state(struct v4l2_subdev *sd,
struct v4l2_subdev_state *sd_state) struct v4l2_subdev_state *sd_state)
{ {
unsigned int i; struct v4l2_mbus_framefmt *mf;
for (i = 0; i < sd->entity.num_pads; i++) {
struct v4l2_mbus_framefmt *mf;
mf = v4l2_subdev_state_get_format(sd_state, i); mf = v4l2_subdev_state_get_format(sd_state, 0);
*mf = fmt_default; *mf = fmt_default;
}
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment