Commit 32a42c93 authored by Matthew Brost's avatar Matthew Brost

drm/xe: Free job before xe_exec_queue_put

Free job depends on job->vm being valid, the last xe_exec_queue_put can
destroy the VM. Prevent UAF by freeing job before xe_exec_queue_put.

Fixes: dd08ebf6 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: default avatarMatthew Brost <matthew.brost@intel.com>
Reviewed-by: default avatarNirmoy Das <nirmoy.das@intel.com>
Reviewed-by: default avatarJagmeet Randhawa <jagmeet.randhawa@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240820202309.1260755-1-matthew.brost@intel.com
parent 60db6f54
...@@ -171,12 +171,13 @@ void xe_sched_job_destroy(struct kref *ref) ...@@ -171,12 +171,13 @@ void xe_sched_job_destroy(struct kref *ref)
struct xe_sched_job *job = struct xe_sched_job *job =
container_of(ref, struct xe_sched_job, refcount); container_of(ref, struct xe_sched_job, refcount);
struct xe_device *xe = job_to_xe(job); struct xe_device *xe = job_to_xe(job);
struct xe_exec_queue *q = job->q;
xe_sched_job_free_fences(job); xe_sched_job_free_fences(job);
xe_exec_queue_put(job->q);
dma_fence_put(job->fence); dma_fence_put(job->fence);
drm_sched_job_cleanup(&job->drm); drm_sched_job_cleanup(&job->drm);
job_free(job); job_free(job);
xe_exec_queue_put(q);
xe_pm_runtime_put(xe); xe_pm_runtime_put(xe);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment