Commit 34574130 authored by Linus Torvalds's avatar Linus Torvalds

Arnd's new-and-improved _IOx() argument checking showed two sound

drivers whose microcode load ioctl's used types with sizes that
overflow the ioctl number. Mark them _IOx_BAD() to document the fact.
parent d6a79f27
...@@ -71,7 +71,8 @@ struct _snd_hdsp_firmware { ...@@ -71,7 +71,8 @@ struct _snd_hdsp_firmware {
unsigned long firmware_data[24413]; unsigned long firmware_data[24413];
}; };
#define SNDRV_HDSP_IOCTL_UPLOAD_FIRMWARE _IOW('H', 0x42, hdsp_firmware_t) /* This ioctl is marked bad because the type is bigger than the IOCTL description */
#define SNDRV_HDSP_IOCTL_UPLOAD_FIRMWARE _IOW_BAD('H', 0x42, hdsp_firmware_t)
typedef struct _snd_hdsp_version hdsp_version_t; typedef struct _snd_hdsp_version hdsp_version_t;
......
...@@ -14,6 +14,8 @@ struct sscape_microcode ...@@ -14,6 +14,8 @@ struct sscape_microcode
}; };
#define SND_SSCAPE_LOAD_BOOTB _IOWR('P', 100, struct sscape_bootblock) #define SND_SSCAPE_LOAD_BOOTB _IOWR('P', 100, struct sscape_bootblock)
#define SND_SSCAPE_LOAD_MCODE _IOW('P', 101, struct sscape_microcode)
/* This ioctl is marked bad because the type is bigger than the IOCTL description */
#define SND_SSCAPE_LOAD_MCODE _IOW_BAD('P', 101, struct sscape_microcode)
#endif #endif
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment