Commit 4504f0e5 authored by Wen Gong's avatar Wen Gong Committed by Kalle Valo

ath10k: sdio: workaround firmware UART pin configuration bug

On QCA6174 SDIO devices the SDIO interrupt will fail if UART is
disabled from ath10k. SDIO firmware enables UART printouts by
default. If ath10k will try to enable UART again the firmware
will configure it's GPIO line incorrectly and SDIO interrupts
won't work anymore. The workaround is to set UART pin again (19
for QCA6174 SDIO) if uart_print is 0.

Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00007-QCARMSWP-1.
Signed-off-by: default avatarWen Gong <wgong@codeaurora.org>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent db5e323f
...@@ -2065,8 +2065,16 @@ static int ath10k_init_uart(struct ath10k *ar) ...@@ -2065,8 +2065,16 @@ static int ath10k_init_uart(struct ath10k *ar)
return ret; return ret;
} }
if (!uart_print) if (!uart_print && ar->hw_params.uart_pin_workaround) {
ret = ath10k_bmi_write32(ar, hi_dbg_uart_txpin,
ar->hw_params.uart_pin);
if (ret) {
ath10k_warn(ar, "failed to set UART TX pin: %d", ret);
return ret;
}
return 0; return 0;
}
ret = ath10k_bmi_write32(ar, hi_dbg_uart_txpin, ar->hw_params.uart_pin); ret = ath10k_bmi_write32(ar, hi_dbg_uart_txpin, ar->hw_params.uart_pin);
if (ret) { if (ret) {
......
...@@ -606,6 +606,11 @@ struct ath10k_hw_params { ...@@ -606,6 +606,11 @@ struct ath10k_hw_params {
/* target supporting fw download via diag ce */ /* target supporting fw download via diag ce */
bool fw_diag_ce_download; bool fw_diag_ce_download;
/* need to set uart pin if disable uart print, workaround for a
* firmware bug
*/
bool uart_pin_workaround;
}; };
struct htt_rx_desc; struct htt_rx_desc;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment